Levandor

mando-cli — Removing bess-os-algo-forecast-as (AsForecast)

2 min read

Removed the obsolete bess-os-algo-forecast-as project (Project::AsForecast) from mando-cli per Andras’s decision. Working tree, uncommitted (pending push). The load-bearing lesson: deleting an enum variant used as a persisted-state map key silently wiped saved state until fixed.

What was removed

Compiler-driven removal — deleted the variant, then followed every build error:

  • Project::AsForecast enum variant
  • Its slug + aliases
  • Its config default YAML
  • Builtin profiles mocked-algos / full / fast-dev — now 4 services each (was 5)
  • e2e fixtures + docs truth pass: README (now five repos / two algos), skill table, datadog guide

The lesson

Deleting an enum variant = audit every persisted format keyed by it before shipping

Project::AsForecast was used as a key in the persisted HashMap<Project, _> inside .bessstate.json. The derived map deserialization fails on a stale "AsForecast" key, and the unwrap_or_default fallback then silently wipes the entire projects map — every override and toggle — which the next save() dutifully persists. Silent data loss, no error surfaced.

How it was caught: the first implementer casually removed the e2e fixture’s AsForecast state entry “so it would deserialize.” That dodge was the tell — the real bug was that a real user’s on-disk state would break the same way.

Fix

Per-key tolerant map deserialization (filter_known_projects) that mirrors save()’s key format:

  • Keys are PascalCase variant names (what save() writes), so resolve via Project::deserialize on a StrDeserializer — explicitly NOT from_alias (lowercase slugs), which would have silently dropped every non-Mando entry.
  • warn! per dropped/unknown key so loss is visible.
  • Red-green tested with a mixed-keys state file.
  • e2e fixture entry restored as a live regression guard (not deleted).

Also verified

  • User .runprofiles/*.yaml naming the dead slug fail cleanly: validate errors “not a known project”; compose warn-skips.
  • Leftover bess-os-algo-forecast-as/ directories in existing workspaces are ignored gracefully.

Gate

  • Reviewer approved all areas.
  • 403 lib + 8 integration tests, clippy 0.

Graph View

Backlinks